minimega: add `tar:` prefix #1130
Merged
Conversation
Fetches and untars tarballs via meshage. Current only untars if there is a single top-level directory. It untars to the same directory that contains the tarball... we probably don't want that when the tarball is in the iomBase. Maybe it would be better to always untar to /tmp/minimega/???.
|
LGTM |
djfritz
merged commit df76cb0
into
sandia-minimega:master
1 check passed
1 check passed
|
@jcrussell merged so let's see how this goes - my opinion is iomBase is the better place, but let's see what feedback we get. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fetches and untars tarballs via meshage. Current only untars if there is
a single top-level directory. It untars to the same directory that
contains the tarball... we probably don't want that when the tarball is
in the iomBase. Maybe it would be better to always untar to
/tmp/minimega/???.
Thoughts? @djfritz