Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega: add `tar:` prefix #1130

Merged
merged 1 commit into from Jun 21, 2018
Merged

minimega: add `tar:` prefix #1130

merged 1 commit into from Jun 21, 2018

Conversation

@jcrussell
Copy link
Contributor

@jcrussell jcrussell commented Jun 20, 2018

Fetches and untars tarballs via meshage. Current only untars if there is
a single top-level directory. It untars to the same directory that
contains the tarball... we probably don't want that when the tarball is
in the iomBase. Maybe it would be better to always untar to
/tmp/minimega/???.

Thoughts? @djfritz

Fetches and untars tarballs via meshage. Current only untars if there is
a single top-level directory. It untars to the same directory that
contains the tarball... we probably don't want that when the tarball is
in the iomBase. Maybe it would be better to always untar to
/tmp/minimega/???.
@jcrussell jcrussell added this to the 2.5 milestone Jun 20, 2018
Copy link
Contributor

@djfritz djfritz left a comment

LGTM

@djfritz djfritz merged commit df76cb0 into sandia-minimega:master Jun 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@djfritz
Copy link
Contributor

@djfritz djfritz commented Jun 21, 2018

@jcrussell merged so let's see how this goes - my opinion is iomBase is the better place, but let's see what feedback we get.

@jcrussell jcrussell deleted the jcrussell:issue-964 branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.