minicli: speed up compilation #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main idea is to store the handlers in a trie so that we can lookup the handler for an input quickly.
Use trie-like data structure to store the patterns and compile commands as we walk it. This is hopefully much faster than the old approach. Need to fix help still -- it reports a bunch of duplicates.
Able to run commands properly. Initial profiling results look good.
Make sure that we don't show help for the same handler twice.
We no longer set the pattern for compiled commands because we don't track that info. Update tests to reflect this. Remove ambiguous command test -- ping and ping6. This should not be allowed.
Closed
|
Found a bug, currently doesn't copy minicli flags to subcommands (e.g. preprocess): |
Fixes `namespace foo shell ls file:test`.
|
And another: |
namespace foo cc process kill all 2018/11/13 07:35:54 WARN trie.go:180: ambiguous command, found 2 possibilities Shouldn't be ambiguous since we have one exact match and one prefix match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index patterns into a trie-like data structure and then compile commands by walking the trie.