minimega,qmp: add "force" option to vm cdrom eject

[jcrussell]

Allow override of guest's "locked" cdrom. Needs testing.

Fixes #1256.

[jcrussell]

@mkunz7: can you test that this works for you?

[mkunz7]

change needs a force as well...

It didn't seem to help osx though, I still have to run those commands to eject the disk before ejecting in mini and and before changing iso

[jcrussell]

Does the debug log still look like:

2019/02/20 11:44:37 DEBUG qmp.go:116: qmp write: map[string]interface {}{"execute":"eject", "arguments":map[string]interface {}{"device":"ide0-cd0"}}
2019/02/20 11:44:37 DEBUG qmp.go:111: qmp read: map[string]interface {}{"error":map[string]interface {}{"class":"GenericError", "desc":"Device 'ide0-cd0' is locked and force was not specified, wait for tray to open and try again"}}

Or can you see the "force" parameter in the arguments?

[mkunz7]

Just tested the latest, the force function works. Thank you. You still need to run the os commands to release the drive though. This will have to work for now until qemu patches the function they call to tell the os the drive has been ejected.

[mkunz7]

if http://philjordan.eu/osx-virt/ ever writes the virtio-scsi driver for osx I think you could hotplug scsi cdroms from hmp

device_add virtio-scsi-pci
drive_add 0 file=/home/ubuntu/a.iso,if=none,id=test,readonly=on,format=raw
device_add scsi-cd,drive=test

[djfritz]

LGTM