Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesh: various tweaks #1319

Merged
merged 6 commits into from
May 24, 2019
Merged

mesh: various tweaks #1319

merged 6 commits into from
May 24, 2019

Conversation

jcrussell
Copy link
Contributor

@jcrussell jcrussell commented May 2, 2019 •
edited
Loading

Various minor tweaks:

  • mesh size is one when there is only a single node
  • add completion for mesh send, mesh hangup, vm config schedule, ns add-hosts and ns del-hosts.
  • Add mesh list peers and mesh list all subcommands.
  • Resolve localhost for vm config schedule.

Fixes #1308

@jcrussell
minimega: split mesh commands into _cli file
47a4e60 
Follow pattern from most of minimega.
@jcrussell
meshage: always add local node to mesh
ea092bc 
So that if a mesh has no peers, it's at least size 1.

Need to do some testing to make sure this doesn't break anything.
@jcrussell
minimega: add mesh list subcommands
42d34b9 
List peers or all nodes in mesh.
@jcrussell
minimega: comletion for hostname
a54687e 
Add completion for hostnames based on nodes in the mesh.
@jcrussell
minimega: suggest for vm config schedule
d9ff61f 
Suggests any node in the mesh, not limited to currently in the
namespace.
@jcrussell
minimega: resolve localhost for validSchedule
d6b9b3f 
Before would reject `vm config schedule localhost`.
@jcrussell jcrussell added this to the 2.6 milestone May 2, 2019
djfritz
djfritz approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@djfritz djfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djfritz djfritz merged commit 031affb into sandia-minimega:master May 24, 2019
@jcrussell jcrussell deleted the mesh-tweaks branch May 24, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djfritz djfritz djfritz approved these changes

Assignees

@djfritz djfritz

Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

Feature Request: ns add-hosts autocompletion
2 participants
@jcrussell @djfritz