Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega: remove dead code, fix error checking on 'vm config net' when only using containers #1380

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

djfritz
Copy link
Contributor

@djfritz djfritz commented Oct 24, 2019

See summary. This is probably the best compromise of possible solutions to mingling container and kvm fields.

fixes #1376

Copy link
Contributor

@jcrussell jcrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djfritz djfritz merged commit 0d41f86 into sandia-minimega:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minimega: don't error on kvm when configuring networks for containers
2 participants