Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniweb: Update packages to latest versions #1382

Merged
merged 3 commits into from
Nov 11, 2019

Conversation

mpopple
Copy link
Contributor

@mpopple mpopple commented Oct 28, 2019

Packages include:
jQuery (3.1.1 -> 3.4.1)
dataTables (1.10.12 -> 1.10.20)
bootstrap (3.3.5 -> 4.3.1)

dataTables: 1.10.12 -> 1.10.20
bootstrap: 3.3.5 -> 4.3.1

Replaced libraries with minified versions and added missing CSS map files.
@djfritz djfritz self-requested a review October 31, 2019 14:08
@djfritz
Copy link
Contributor

djfritz commented Nov 7, 2019

@mwisely can you comment? There's no clean way to test this so I think we just need a sanity check re: versioning etc. Nobody knows this stuff on our team better than you.

@mwisely
Copy link
Contributor

mwisely commented Nov 8, 2019

@mpopple @djfritz It seems to work for me, so far. The listed versions appear to be the latest stable releases, and my JS console is clear.

I'm curious if we'll see any weirdness from updating Bootstrap 3.x to 4.x, but we can handle that if/when it arises.

Looks good to me, though!

Copy link
Contributor

@djfritz djfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djfritz djfritz merged commit 71d4680 into sandia-minimega:master Nov 11, 2019
@mpopple mpopple deleted the update-datatables-bootstrap branch November 18, 2019 19:52
@mpopple
Copy link
Contributor Author

mpopple commented Nov 20, 2019

Thanks @djfritz and @mwisely !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants