Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "side-effects" to be "incidentals" #298

Open
wwitzel opened this issue Aug 19, 2022 · 0 comments
Open

Rename "side-effects" to be "incidentals" #298

wwitzel opened this issue Aug 19, 2022 · 0 comments

Comments

@wwitzel
Copy link
Collaborator

wwitzel commented Aug 19, 2022

Deepak has always objected to "side-effects" as they have a negative connotation in formal methods. I do think "incidentals" is an appropriate name. Instead of a "side_effects" Expression method, we should use "_yield_incidentals" with an underscore to indicate that this is not normally called externally. It is called in Judgment.derive_side_effects which will become Judgment.derive_incidentals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant