-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kokkos::vector'is deprecated #1019
Comments
I don't think we use it very heavily. Only to carry around a vector of device views. Hopefully there's an easy replacement. |
I think Kokkos::vector is just a special case of a DualView, so we can probably switch do Kokkos::DualView without too much disruption. And yes, I think we only use it in gather/scatter evaluators. |
I guess the errors in the weaver nightlies that started today are unrelated? https://sems-cdash-son.sandia.gov/cdash/viewBuildError.php?buildid=54850
Does anyone have any insight into this new error? |
yeah that's different. Not sure what happened. I can take a look tomorrow if it happens again. |
Thanks @jewatkins that would be great. We can open a new issue, as needed, based on what you find. |
@jewatkins @bartgol @mcarlson801 @kliegeois Anybody willing to take this on? |
is it going to be removed soon from trilinos/kokkos? |
Not sure, but probably it won't go away until next major release of Kokkos. However, the warning is kind of annoying and it's a good spring cleaning task. |
I'll take a look at this today. |
* Remove Kokkos::vector - fix #1019
I started to see this warning since I upgraded Trilinos:
While I don't expect the class to disappear very soon, we should be proactive, and remove its usage. We don't want to forget and have to rush it when Kokkos finally removes it.
The text was updated successfully, but these errors were encountered: