Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings to notebook reports about jupyter-lab compatibility #328

Closed
coreyostrove opened this issue Jul 7, 2023 · 1 comment
Closed
Assignees
Labels
bug A bug or regression enhancement Request for a new feature or a change to an existing feature
Milestone

Comments

@coreyostrove
Copy link
Contributor

This is not a new problem, but the notebook option for GST reports is, and likely will continue to be, incompatible with jupyterlab. This isn't well documented in pygsti, however, which is easy to fix. We should do the following:

  1. Have the write_notebook method for reports produce a warning alerting users to the compatibility problem. Similarly add a note to the docstring.
  2. Add a note to the reporting tutorial.
  3. Add a note at the top of the produced .ipynb file itself.
@coreyostrove coreyostrove added bug A bug or regression enhancement Request for a new feature or a change to an existing feature labels Jul 7, 2023
@coreyostrove coreyostrove self-assigned this Jul 7, 2023
@sserita sserita added the fixed-but-not-in-release-yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Aug 11, 2023
@sserita
Copy link
Contributor

sserita commented Aug 11, 2023

Fixed on branch bugfix-example-updates via commit a0e4d5d. This branch will stay open for now while we get fixes for #317 in as well.

@sserita sserita added this to the 0.9.12.1 milestone Nov 29, 2023
@sserita sserita closed this as completed Feb 2, 2024
@sserita sserita removed the fixed-but-not-in-release-yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or regression enhancement Request for a new feature or a change to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants