Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial updates #395

Merged
merged 12 commits into from
Feb 2, 2024
Merged

Tutorial updates #395

merged 12 commits into from
Feb 2, 2024

Conversation

sserita
Copy link
Contributor

@sserita sserita commented Jan 31, 2024

This PR is only a partial completion of #317, but I'm including the current bugfixes in the next minor release because there is no reason to wait on all the updates and these include some high-visibility/-utility updates.

Included in this PR are the following items from #317:

  • Experiment design construction tutorials (for using/explaining new germ, fiducial and FPR tools). Maybe a new tutorial on using the fisher information to evaluate experiment designs
  • Parity POVM example
  • Specifying reduced error generator models using new coefficient block interface
  • 00-Protocols tutorial issues
  • 01-Esssential-Objects tutorial issues
  • 02-Using-Essential-Objects tutorial issues
  • CustomOperator tutorial issues

This PR also fixes the following related issues:

@sserita sserita marked this pull request as ready for review January 31, 2024 01:35
@sserita sserita requested review from pcwysoc and a team as code owners January 31, 2024 01:35
@sserita sserita requested review from kmrudin and removed request for coreyostrove January 31, 2024 01:35
@sserita
Copy link
Contributor Author

sserita commented Jan 31, 2024

Woot I think this is our first PR that is pulling in code owners outside of the dev team, which means that @coreyostrove you are off the hook (unless you also wanted to look).

@kmrudin and @pcwysoc: I know this is probably new for you. I'm happy to hop on a Teams call to help with the process. But the TL;DR is:

  1. Go over to the Files Changed tab.
  2. Any file with a blue shield in the top left is one that you are a code owner for. Look over the changes. Red is a removed line, green is an added line. For a changed line, you'll see a red followed immediately by a green, with the thing that is changed being highlighted.
  3. If you want to leave a comment, you can click on the line number and leave your comment.
  4. When you are done with a file, you can click on the Viewed box in the top right and move to the next one.
  5. When you have done all the files, click Review Changes in the top right above the files and either Approve if all looks good, Request changes if something looks bad, and Comment if you have questions but are not explicitly approving/rejecting.

If you come across a file that you are not a code owner for, feel free to skip it. If you come across a file that you ARE a code owner for and don't feel comfortable reviewing it, please comment that in the review - I can get someone else to review and then alter code owners appropriately.

@pcwysoc I think you are on this just for a single file, which might be the reports? In which case this should be a quick review for you 🤣

@kmrudin Unfortunately, Jupyter notebooks are particularly annoying to review here. For the typo updates, this should be relatively OK, but for the ModelNoise.ipynb and CustomMeasurement.ipynb, you may find it helpful to look at the tutorial notebooks here. For ModelNoise, the "Reduced error models" section is new, and the entire notebook is new for CustomMeasurement.

@sserita sserita added this to the 0.9.12.1 milestone Jan 31, 2024
Copy link

@pcwysoc pcwysoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short bit I'm on the hook for looks good to me.

Copy link
Contributor

@kmrudin kmrudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes; discussed with Stefan.

@sserita sserita merged commit 60fa2d5 into develop Feb 2, 2024
4 checks passed
@sserita sserita deleted the bugfix-example-updates branch February 2, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants