Clean up Python 2 compatibility duct-tape #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed function performed cross-version string typechecking using `basestring`, which has been removed since Python 3.0. Use `isinstance(x, str)` instead.
PEP 237 removes distinctions between `long` and `int`. `int` should be used exlusively.
Our rationale is that Ubuntu 16 (Xenial), the earliest release still under standard support, ships with Python 3.5. We plan to continue Python 3.5 support at least through April 2021, when Xenial support is dropped.
Python 3 will be assumed for the forseeable future. Additionally, reference file regeneration checking has been consolidated into `testutils.basecase.regenerate_references()`, which simply checks if the environment variable `PYGSTI_REGEN_REF_FILES` has been set. Note that any value will cause references to be regenerated.
…p_chk_files` If any necessary files were removed by mistake, feel free to revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #90, which should only be closed after the first major release with this patch.
This patch also (unavoidably) cleans up unused static test fixtures from
test.test_packages.cmp_chk_files. If anything removed should have been kept, please add it back in.