Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix For ReadTheDocs and Documentation Build Updates #331

Merged
merged 19 commits into from
Aug 10, 2023

Conversation

coreyostrove
Copy link
Contributor

This PR includes the following:

  1. Migration from autodoc/autosummary for sphinx documentation generation to autoapi including associated custom configuration changes and some tweaks to the default templating to better suit our needs.
  2. This migration fixes the failed RTD builds we were encountering due to timeouts. autoapi runs statically using source code parsing rather than directly importing modules and as such runs much more quickly (putting us back well within the resource limits on RTD).
  3. A large number of fixes to the docstrings themselves to address sphinx build errors and warnings. Most of these involved either updated sphinx keywords or restructured text markup errors. I got as many of the build errors sorted as I knew how to, but there are still a few remaining warnings (related to duplicated object entries) but these don't seem to be important errors for the time being.

Once this PR is approved I'll update the settings on RTD to switch our documentation builds from running against this bugfix branch back to develop and master.

coreyostrove and others added 19 commits August 27, 2021 12:20
Removed a reference to the deprecated "sample" which was causing an import error.
pygsti.evotype->pygst.evotypes
crosstalk module uses pcalg and throws an import error if not installed.
pcalg is needed for the crosstalk module.
The _dbcoordinates attribute doesn't seem to be getting included when pickling and unpickling dataset objects which happens under the hood when using MPI. Temporary patch until I identify the longer term fix.
Add the language to address deprecation warning in sphinx
This commit shift the sphinx automatic documentation generation based on extracted docstrings to use the autoapi extensions. This runs statically by analyzing the source code instead of by performing module imports, so this should in principle run a good deal faster and alleviate resource limitations on RTD. Also included are some custom tweaks to the default autoapi documentation template to (in my opinion) look a bit better.
The keywords used for sphinx cross-referencing in many docstrings was incorrect which was raising a large number of warnings. This is a wholesale find and replace of all of those instances with the corrected ones.
First round of fixes for sphinx/rst formatting errors related to docstrings. More to come...
Add the sphinx rtd theme package and autoapi package to the requirements file for doc building.
This commit updates the minimum version for sphinx used for building the documentation. It also adds a yaml file for the RTD configuration settings in accordance with new requirements from them. They have deprecated the ability to configure build settings through the online dashboard and will disable builds w/o this file in the fall.
There appears to be an incompatibility between sphinx 7+ and one of the themes we're using so pinning the sphinx version to one which successfully builds locally.
Force a more recent version of the sphinx rtd theme to be used than the default on RTD and also remove an unused requirements file from the doc folder.
This is another round of updates to fix a large number of sphinx build errors and warnings related to malformed rst markup.
Another batch of docstring fixes.
Somehow this import got deleted, not sure how (maybe I accidentally did this during one of the find and replaces?) but this should sync things back up with master.
@sserita sserita merged commit cfa183f into develop Aug 10, 2023
13 checks passed
@sserita sserita deleted the bugfix-readthedocs branch August 10, 2023 20:09
@sserita sserita mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants