Bugfix numpy125 deprecations #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2023 23:33
This commit switches the cirq dependency to cirq-core from cirq. Recently we've begun having pip installation issues due to unresolvable dependency conflicts. I traced this back to cirq, and while I haven't definitely proven this think that it is specifically a dependency issue with the cirq-rigetti submodule. When installing cirq it will by default include all of the optional submodules, most of which are specific hardware platform interface code which isn't needed for our purposes (which is just the ability to output cirq circuit objects). So we should be fine switching to cirq-core and avoiding installation of all of the extra submodules altogether. If a user wants that they can figure out the dependency issues for whichever hardware backend they want to connect to with cirq on their end.
product was deprecated and now gives a warning. A couple of our unit tests were tripping up because of this now, so this function call swap should in principle fix that.
sserita
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product was deprecated in numpy 1.25 and now gives a warning. A couple of our unit tests were tripping up because of this now, so this function call swap (product->prod) should in principle fix that.