Enhances EmbeddingOpFactory to be used to create target-qubit-dependent operation factories #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded factory. Previously, when an EmbeddingOpFactory was called on to create an operation for a set of state space labels (sslbls) it would *not* pass these labels to the contained (embedded) factory. The thinking (if I remember correctly) was that this information wouldn't be needed by the contained factory since the EmbeddingOpFactory would handle all of the embedding. While this latter statement is true the contained factory *does* need the sslbls if its job is to create different operations on different target qubits - even though the operation being constructed is a local (e.g. 2-qubit out of the N total qubits) one. Previously in the call to EmbeddedOpFactory.create_op `None` as passed down to the contained factory's create_op call instead of the original `sslbls`. This commit updates this so that `sslbls` is passed through. This means that in UnitaryOpFactory and in user-defined factories the `sslbls` parameter of create_op will no longer be `None` all the time (specifically when such factories are used with EmbeddingOpFactory objects) and so assertions that this be the case have been removed from UnitaryOpFactory and the user-defined factory in the OperationFactories.ipynb tutorial notebook.
sserita
approved these changes
Aug 15, 2023
sserita
added a commit
that referenced
this pull request
Sep 13, 2023
This should fix the extra tests broken since PR #338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alters behavior of
EmbeddingOpFactoryto pass state space labels of operations being created through to a contained (embedded) operation factory object.Previously, when an EmbeddingOpFactory would "blank out" (set to
None) thesslblsargument passed to the contained op-factory'screate_opcall. Now this argument receives the originalsslblsand so the contained factory can use this information to create different operations depending on what the operation's target qubits are.This PR updates assertions in
UnitaryOpFactoryand an example in the operation factory tutorial that no longer hold in generatlity.