Fix mutable defaults #357
Merged
Fix mutable defaults #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyjmurray
commented
Oct 18, 2023
rileyjmurray
commented
Oct 18, 2023
|
IMO: ready to merge, once #357 (comment) is addressed. |
|
@sserita: ready to merge as far as I'm concerned. |
sserita
approved these changes
Oct 18, 2023
|
I agree that this is ready. I'll wait until the tests on beta pass from the other big PR before merging this in though (even after these are passing). |
|
@sserita, did the tests on beta pass for the other PR you mentioned? If so, can you merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve #355.
When I tested these changes, I found that some code still called
pygsti.obj, even though this subpackage was renamed topygsti.baseobjssome time ago. This PR also replaces all instances ofpygsti.obj.withpygsti.baseobjs.to fix that.