Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ibm device #359

Merged
merged 11 commits into from
Nov 17, 2023
Merged

Feature ibm device #359

merged 11 commits into from
Nov 17, 2023

Conversation

sserita
Copy link
Contributor

@sserita sserita commented Oct 27, 2023

This branch deprecates the majority of pygsti.extras.devices.devcore in favor of the new pygsti.extras.devices.ExperimentalDevice.

An ExperimentalDevice can be created in two ways:

  1. By passing in a device name, which uses the now legacy device files in pygsti.extras.devices. This is provided mainly for backwards compatibility and in case you are working offline (or with a retired IBMQ device).
  2. By passing in an active IBMQ backend (which is the intended default workflow).

I still have several bugfixes that I will push on this branch before it is ready, including:

  • IBMQ.write() bug
  • 'id' instruction deprecation
  • Deprecation of IBMQ to qiskit-ibm-provider

But I'm putting the PR up early to get feedback from IBMQ users. The tutorial should be up to date on usage if you don't feel like reading code

sserita and others added 8 commits October 27, 2023 13:13
This is a deprecation of the majority of devcore.py,
which is now replaced by ExperimentalDevice.
For legacy purposes, the old device files can be loaded;
however, the intended use is to pass an active IBMQ backend into ExperimentalDevice
and create a pspec from current device connectivity data.
Should fix the `id` deprecation warning when running on IBMQ
(has been deprecated since 0.15).
Should probably be reworked to include stretch when openqasm3 becomes standard.
This is not a completely satisfactory fix,
but the complete fix involves
figuring out how to implement
nice serialization for all model members (aside from MMGraph).
@sserita
Copy link
Contributor Author

sserita commented Oct 28, 2023

Pending no other major feedback this week, I think this is ready to be merged in.

@sserita sserita merged commit 320bdf3 into develop Nov 17, 2023
13 checks passed
@sserita sserita deleted the feature-ibm-device branch November 17, 2023 17:12
@sserita sserita mentioned this pull request Nov 17, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants