-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature ibm device #359
Merged
Merged
Feature ibm device #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a deprecation of the majority of devcore.py, which is now replaced by ExperimentalDevice. For legacy purposes, the old device files can be loaded; however, the intended use is to pass an active IBMQ backend into ExperimentalDevice and create a pspec from current device connectivity data.
Should fix the `id` deprecation warning when running on IBMQ (has been deprecated since 0.15). Should probably be reworked to include stretch when openqasm3 becomes standard.
This is not a completely satisfactory fix, but the complete fix involves figuring out how to implement nice serialization for all model members (aside from MMGraph).
Pending no other major feedback this week, I think this is ready to be merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch deprecates the majority of
pygsti.extras.devices.devcore
in favor of the newpygsti.extras.devices.ExperimentalDevice
.An
ExperimentalDevice
can be created in two ways:pygsti.extras.devices
. This is provided mainly for backwards compatibility and in case you are working offline (or with a retired IBMQ device).I still have several bugfixes that I will push on this branch before it is ready, including:
IBMQ
toqiskit-ibm-provider
But I'm putting the PR up early to get feedback from IBMQ users. The tutorial should be up to date on usage if you don't feel like reading code