Implement CODEOWNERS #384
Implement CODEOWNERS #384
Conversation
Add Piper as code owner for instruments, workspace plots/tables, and associated tutorials
Add Tim and Jordan as drift/RB and RB code owners, respectively. Also create a pygsti-maintainers team instead of calling out specific maintainers, as a future-proofing mechanism.
Using the new pygsti-rb team to head off email spam One annoyance of Code Owners is that PRs auto add all code owners, UNLESS they are part of team that has auto assign enabled. In this case, I've made a pygsti-rb team that auto-assigns between Jordan and Tim in a round robin way. Hopefully this will keep emails down. One note: This is not really needed for one user code owners since they will just get the notification and the pygsti-maintainers team also has round-robin applied.
|
So one annoyance I've been reading about with code owners is email spam because every PR auto-assigns a review to all code owners. As far as I can tell, there is only ONE exception to this: When a code owner is a team, that team can be set to auto-assign to a member within the team and NOT email everyone else. With this in mind, I have settled on the following approach:
We currently have this happening twice: once for the maintainers and once for RB. Here are the relevant settings for pygsti-maintainers, with the important boxes surrounded in red: And here we have pygsti-rb, which is similar. However, in this case, I have to be part of the group to maintain it but I don't want to count towards the RB reviewer quota, so we tell GitHub to skip me: |
|
I'll note that my previous solution has the added benefit that code owners for subteams can be changed out without requiring a modification of CODEOWNERS in the future. |
|
@sserita I like the idea of creating subteams |
Add pygsti-gatekeepers as owner everywhere The intention will be that develop will require 2 approvals. One will be the "subject matter" owner, and the other will by a pyGSTi gatekeeper (Sandia staff member). In cases with only one gatekeeper and the gatekeeper is submitting a PR, this may require a branch protection bypass, but that might be OK. TBD on how it all works out.
Added Kenny as code owner for RPE, tutorials, instruments Moved Riley to core functionality from maintainers
Implement a CODEOWNERS file for pyGSTi to modernize our PR pipeline.
This branch/PR will stay open as we get volunteers in. Edit: We now have all the volunteers and subteams set up.