WIP: PyTorch-backed forward simulation #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is WIP, can we keep it as a draft? While in draft mode, it does not assign reviewers/auto-request reviews from code owners, so that seems like the best workflow for not overloading email inboxes while something is not ready for review yet. |
|
@sserita, marked! Sorry. I'm not used to the formal draft feature. Can you remove the reviewers who were already assigned? GitHub says it'll keep pinging them whenever I update this. If you don't see how do that then I can close and open a new PR. |
|
Superseded by #390. |
|
No worries! Reviewers can turn off the notifications themselves and/or remove themselves, but I think the new issue is cleaner - that way, I'll make sure to get the emails whenever you turn it into not draft mode :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Status
Jan 17: Just creating this to share WIP. Nothing useful as of yet.