Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTorch-backed forward simulation #390

Open
wants to merge 64 commits into
base: develop
Choose a base branch
from
Open

PyTorch-backed forward simulation #390

wants to merge 64 commits into from

Commits on Jan 17, 2024

  1. resolve deprecation warning

    @rileyjmurray
    rileyjmurray committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fbe23e9 View commit details
    Browse the repository at this point in the history

  2. tiny bugfix

    @rileyjmurray
    rileyjmurray committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    985404f View commit details
    Browse the repository at this point in the history

  3. starting point for building the TorchForwardSimulator class

    @rileyjmurray
    rileyjmurray committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8f36247 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. notes

    @rileyjmurray
    rileyjmurray committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    842c0f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. infrastructure

    @rileyjmurray
    rileyjmurray committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    1b698e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. I understand how I am stuck and will get help

    @rileyjmurray
    rileyjmurray committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    cbc15b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. change list comprehension into for-loop in order to simplify setting … 

    …breakpoints in debugging
    @rileyjmurray
    rileyjmurray committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b3ac3da View commit details
    Browse the repository at this point in the history

  2. leave comments describing object inheritance structures for states, p… 

    …ovms, and gates (as they appear in TorchOpModel._compute_circuit_outcome_probabilities)
    @rileyjmurray
    rileyjmurray committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    73363d1 View commit details
    Browse the repository at this point in the history

  3. comments indicating class types of povm-related objects

    @rileyjmurray
    rileyjmurray committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9983d1b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. improve readability

    @rileyjmurray
    rileyjmurray committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    bd345f6 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary dependence of certain Evotypes on trivial Cython b… 

    …ase classes
    @rileyjmurray
    rileyjmurray committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2e76f32 View commit details
    Browse the repository at this point in the history

  3. left out of last commit

    @rileyjmurray
    rileyjmurray committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    bd82b41 View commit details
    Browse the repository at this point in the history

  4. comments explaining that densitymx_slow is really "superket_slow"

    @rileyjmurray
    rileyjmurray committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e158c21 View commit details
    Browse the repository at this point in the history

  5. left out of last commit

    @rileyjmurray
    rileyjmurray committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c6b4d8f View commit details
    Browse the repository at this point in the history

  6. remove commented-out functions which I now clearly understand we do n… 

    …ot need
    @rileyjmurray
    rileyjmurray committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ae73090 View commit details
    Browse the repository at this point in the history

  7. remove abstraction layers in TorchForwardSimulator

    @rileyjmurray
    rileyjmurray committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ffa7ea0 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. remove more abstractions

    @rileyjmurray
    rileyjmurray committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    d787025 View commit details
    Browse the repository at this point in the history

  2. remove references to new TorchLayerRules class and discussion surroun… 

    …ding attempts to use that class
    @rileyjmurray
    rileyjmurray committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    b510b2e View commit details
    Browse the repository at this point in the history

  3. make an apparent limitation of TorchForwardSimulator (and I suppose a… 

    …lso SimpleMapForwardSimulator ...) that the dict returned by circuit.expand_instruments_and_separate_povm(...) has at most one element.
    @rileyjmurray
    rileyjmurray committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    6fc59dd View commit details
    Browse the repository at this point in the history

  4. remove unused function

    @rileyjmurray
    rileyjmurray committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    6aac2af View commit details
    Browse the repository at this point in the history

  5. explicitly override the function that iterates over circuits and call… 

    …s _compute_circuit_outcome_probabilities
    @rileyjmurray
    rileyjmurray committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    107b26b View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. get array representations of all quantities as prep work before compu… 

    …ting any circuit probabilities
    @rileyjmurray
    rileyjmurray committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c1fcfc2 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. use torch to compute circuit probabilities (infrastructure not in pla… 

    …ce for differentiation yet)
    @rileyjmurray
    rileyjmurray committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    761496c View commit details
    Browse the repository at this point in the history

  2. progress toward bypassing explicit calls to _rep fields of various mo… 

    …delmembers (needed to construct differentiable torch tensors). Have a new torch_base property of TPState objects. Need such a property for FullTPOp objects. Unclear how to implement for povms, since right now we`re bypassing the POVM abstraction and going directly into the effects abstraction of the circuit.
    @rileyjmurray
    rileyjmurray committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    abdfdc7 View commit details
    Browse the repository at this point in the history

  3. more progress on modelmember.torch_base(...) pattern

    @rileyjmurray
    rileyjmurray committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9b56b2a View commit details
    Browse the repository at this point in the history

  4. demonstrate how we can access povm data through the TPPOVM abstractio… 

    …n, rather than only through ConjugatedStatePOVMEffect objects associated with a SeparatePOVMCircuit
    @rileyjmurray
    rileyjmurray committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0c9b103 View commit details
    Browse the repository at this point in the history

  5. write basic TPPOVM.torch_base function. Need to modify that function … 

    …so it allows require_grad=True.
    @rileyjmurray
    rileyjmurray committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    243b757 View commit details
    Browse the repository at this point in the history

  6. forward simulation codepath that computes gradients seems to work. Ha… 

    …vn`t used it to speed up derivative computations yet.
    @rileyjmurray
    rileyjmurray committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0bea829 View commit details
    Browse the repository at this point in the history

  7. can build the entire vector of outcome probabilities as a torch Tenso… 

    …r before converting to a numpy array and writing to array_to_fill in TorchForwardSimulator._bulk_fill_probs_block.
    @rileyjmurray
    rileyjmurray committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b88643a View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. make a function that lets us access the torch representation of compu… 

    …ted circuit probabilities. About to simplify torch_cache.
    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c1eacb3 View commit details
    Browse the repository at this point in the history

  2. simplified torch_cache

    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3ef9502 View commit details
    Browse the repository at this point in the history

  3. step toward what we need for torch jacfwd function

    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    7073544 View commit details
    Browse the repository at this point in the history

  4. progress toward functional evaluation in TPPOVM.torch_base. Need to a… 

    …pply similar conventions to TPState and FullTPOp.
    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    aa5c4e7 View commit details
    Browse the repository at this point in the history

  5. add a static_torch_base function

    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0bc3736 View commit details
    Browse the repository at this point in the history

  6. progress toward statelessness

    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6658c47 View commit details
    Browse the repository at this point in the history

  7. more functional

    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    852d8a6 View commit details
    Browse the repository at this point in the history

  8. created (and put to work) a new StatelessModel helper class

    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b6bc0f0 View commit details
    Browse the repository at this point in the history

  9. I can successfully call jacfwd and get reasonable output. Next step i… 

    …s to figure out how to unpack theresults to match existing pygsti API
    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9855144 View commit details
    Browse the repository at this point in the history

  10. IT IS ALIVE

    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f85716b View commit details
    Browse the repository at this point in the history

  11. note some opportunities for improved efficiency

    @rileyjmurray
    rileyjmurray committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    14f1af4 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. simplified StatelessModel and StatelessCircuit

    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    2c6be95 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary comments

    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    23207f7 View commit details
    Browse the repository at this point in the history

  3. clean up TorchForwardSimulator

    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    3a04a31 View commit details
    Browse the repository at this point in the history

  4. revert change that helped with debugging once-upon-a-time, but wasn`t… 

    … necessary at the end of the day
    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    6c2e5f3 View commit details
    Browse the repository at this point in the history

  5. Have meaningful comments for classes in evotypes/densitymx_slow/

    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    eb79162 View commit details
    Browse the repository at this point in the history

  6. improve comments for classes in evotypes/densitymx_slow/

    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    3461335 View commit details
    Browse the repository at this point in the history

  7. remove unused function

    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    1cc944c View commit details
    Browse the repository at this point in the history

  8. undo change

    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    0e2f051 View commit details
    Browse the repository at this point in the history

  9. removed unused file

    @rileyjmurray
    rileyjmurray committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    cfa9232 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. documentation

    @rileyjmurray
    rileyjmurray committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    cf05d9a View commit details
    Browse the repository at this point in the history

  2. remove comment logged as GitHub Issue #397

    @rileyjmurray
    rileyjmurray committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f312b92 View commit details
    Browse the repository at this point in the history

  3. unify the API for torch_base and getting necessary ModelMember metadata

    @rileyjmurray
    rileyjmurray committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a55efde View commit details
    Browse the repository at this point in the history

  4. remove old comments and unused imports. Style tweaks.

    @rileyjmurray
    rileyjmurray committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a8f6145 View commit details
    Browse the repository at this point in the history

  5. formally declare the stateless_data and torch_base functions in the M… 

    …odelMember API
    @rileyjmurray
    rileyjmurray committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e72dbad View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. reenable commented-out tests in test_forwardsim.py

    @rileyjmurray
    rileyjmurray committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d2c8d38 View commit details
    Browse the repository at this point in the history

  2. gracefully handle when pytorch is not installed

    @rileyjmurray
    rileyjmurray committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2435a50 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. stash

    @rileyjmurray
    rileyjmurray committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    2e4c3cf View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. better workaround for circular imports in type annotations

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a3ffa68 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Create Torchable subclass of ModelMember

    @rileyjmurray
    rileyjmurray committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f5383b9 View commit details
    Browse the repository at this point in the history

  2. remove static constant from TorchForwardSimulator class

    @rileyjmurray
    rileyjmurray committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ac2e8e7 View commit details
    Browse the repository at this point in the history

  3. docstring changes

    @rileyjmurray
    rileyjmurray committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5a1be5d View commit details
    Browse the repository at this point in the history

  4. docstring changes

    @rileyjmurray
    rileyjmurray committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1ec6909 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. clean up TPState constructor. Add documentation for TPPOVM. Change im… 

    …plementation of TPPOVM.stateless_data and TPPOVM.torch_base. Remove unncessary line break in FullTPOp.
    @rileyjmurray
    rileyjmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    957192a View commit details
    Browse the repository at this point in the history

  2. fix handling lack of pytorch

    @rileyjmurray
    rileyjmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    07537f3 View commit details
    Browse the repository at this point in the history