-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature faster testing stuff #403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial round of updates to speed up unit tests and modernize them.
Update unit tests for time dependent GST to speed those up.
Switch from loading old models and datasets from disk to spinning these up from scratch.
I swear we had changed this to have the model copied, but for some reason that ended up reverted...
The default max iteration count for the driver based calls was different than the default behavior for the OO approach. This update brings those two in line.
This commit updates the QutritGST demo to run significantly faster for automated testing purposes. Also includes some changes to the qutrit model building helper utilities to modernize those by switching default parameterization to full TP, from unconstrained full. (This also has the benefit of reducing parameter counts which speeds up runtime).
Updates the tutorial notebook for the drift analysis code to run on a smaller experiment design and thus take a lot less time to run.
More notebook updates aimed at speeding up testing. Main changes here are to switch from XYI to XY in a few places where the gate set isn't particularly important, and to decrease the maximum circuit depth for GST experiment designs in some places.
Minor fix to a unit test to account for changes to qutrit construction code.
Streamline this notebook to speed up execution.
Modernize it to not use a legacy modelpack and use a slightly smaller model to run a bit faster.
Reduce from 3 to two-qubits, and reduce maximum depth a bit.
Needed to update dof counting to account for smaller edesign
Another minor typo fix...
sserita
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your hard work on optimizing these tests Corey. I feel pretty good about our runtime on the workers now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains primarily a set of updates for the unit tests and for the tutorial/example notebooks aimed at reducing their runtime in the CI setting. This also includes some changes modernizing tests/notebooks moving away from use of legacy modelpacks. See issue #380 for a checklist summarizing the notebooks and tests which were identified as bottlenecks which have been addressed. In all cases the changes made are ones that reduce computational requirements without meaningfully impacting either the test coverage, or the message conveyance of a tutorial. E.g. switching from the XYI to the XY gate set in an example to reduce parameter counts (making stuff run more quickly) while still demoing the intended feature/analysis. With all of these changes in place the notebook regression checks now run in almost exactly half the time (at least from spot checking a couple ubuntu runners comparing two-weeks ago to today).
In the mix are also a couple of minor bugfixes/codebase changes. These are: