Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes and efficiency improvements for basis conversion, inner products, and computing Frobenius distance #432

Merged
merged 10 commits into from May 7, 2024
Merged

Bugfixes and efficiency improvements for basis conversion, inner products, and computing Frobenius distance #432

merged 10 commits into from May 7, 2024

Commits on Apr 25, 2024

  1. remove frobeniusnorm and frobeniusnorm_squared functions (which were … 

    …not needed and which were only correct for real inputs). Replace the np.trace(np.dot(...)) pattern for computing the trace inner product with np.vdot(...). Use of np.vdot has a secondary affect of conjugating the first argument when dealing with complex inputs, which resolves a limitation of basis conversion discussed in an email thread.
    @rileyjmurray
    rileyjmurray committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9795d59 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. remove .ravel() when computing Frobenius norm

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    57d3aef View commit details
    Browse the repository at this point in the history

  2. remove _hack_sqrtm and improve efficiency of fidelity calculation

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3f04a92 View commit details
    Browse the repository at this point in the history

  3. check hermicity for both arguments to fidelity funciton

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9714edb View commit details
    Browse the repository at this point in the history

  4. fix awkward function name

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c21a2c4 View commit details
    Browse the repository at this point in the history

  5. fix namespace issue from copy-pasted code; fix nonsense tests in test… 

    …_optools.py::GateOpsTester
    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7c2e160 View commit details
    Browse the repository at this point in the history

  6. left out of last commit

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    183c633 View commit details
    Browse the repository at this point in the history

  7. address Corey`s comments

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    01c636a View commit details
    Browse the repository at this point in the history

  8. remove commented out old code

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ac71e54 View commit details
    Browse the repository at this point in the history

  9. left out of last commit

    @rileyjmurray
    rileyjmurray committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2f3ca3f View commit details
    Browse the repository at this point in the history