Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Replace dot with infix matmul #433

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

WIP: Replace dot with infix matmul #433

wants to merge 7 commits into from

Commits on Apr 25, 2024

  1. remove frobeniusnorm and frobeniusnorm_squared functions (which were … 

    …not needed and which were only correct for real inputs). Replace the np.trace(np.dot(...)) pattern for computing the trace inner product with np.vdot(...). Use of np.vdot has a secondary affect of conjugating the first argument when dealing with complex inputs, which resolves a limitation of basis conversion discussed in an email thread.
    @rileyjmurray
    rileyjmurray committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9795d59 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. initial matmul converter script

    @rileyjmurray
    rileyjmurray committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    da77bc7 View commit details
    Browse the repository at this point in the history

  2. check in before running converter

    @rileyjmurray
    rileyjmurray committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9b7959b View commit details
    Browse the repository at this point in the history

  3. replace calls to .transpose() with .T and replace .conjugate() with .… 

    …conj()
    @rileyjmurray
    rileyjmurray committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c58ed99 View commit details
    Browse the repository at this point in the history

  4. first pass automated dotdot replacement

    @rileyjmurray
    rileyjmurray committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9a1773e View commit details
    Browse the repository at this point in the history

  5. rename functions to make it easier to track transformations

    @rileyjmurray
    rileyjmurray committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f2259ca View commit details
    Browse the repository at this point in the history

  6. Revert "first pass automated dotdot replacement" 

    This reverts commit 9a1773e.
    @rileyjmurray
    rileyjmurray committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5db0672 View commit details
    Browse the repository at this point in the history