Mac allow system ucontext #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janciesko The tests are failing because we also need to remove the end of the case statement. |
janciesko
force-pushed
the
mac-allow-system-ucontext-2
branch
from
4fa9a7d
to
2a368b4
Compare
|
These changes look good. Please check on x86 mac to be sure we didn't mess anything up there -- with no switch to enable or disable fast context it should default to fast context. I will check on m1 mac. |
Just tested on m1 and looks good. Please check on x86 mac to be sure fast context is still used there (and working) by default and also when configured with enable fast context flag set. |
|
Checked and confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes case block in m4 file. This allows to use ucontext on Macs and removes the requirement to use fast context on all Macs. Using fast context is current unsupported on M1 Macs. This resolves the compilation error.