Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete phenix VM injection snapshots when an experiment is stopped #22

Open
activeshadow opened this issue Apr 16, 2021 · 1 comment
Open

Delete phenix VM injection snapshots when an experiment is stopped #22

activeshadow opened this issue Apr 16, 2021 · 1 comment
Assignees
@activeshadow
Labels
question Further information is requested

Comments

@activeshadow
Copy link
Collaborator

Originally created by @activeshadow on Thu, 18 Feb 2021 17:03:55 GMT

Right now, we only delete experiment VM injection snapshots right before an experiment is started and when an experiment is deleted. We don't currently delete them when an experiment is stopped just in case we need to pull an injection out, confirm an injection was added, etc. (essentially for debugging purposes).

I propose we change to deleting the injection snapshots by default when an experiment is stopped and add a flag to the experiment stop command to keep the injection snapshots around if necessary.
@activeshadow activeshadow self-assigned this Apr 16, 2021
@activeshadow
Copy link
Collaborator Author

How would we handle this in the UI? Add a modal that asks the question?

@activeshadow activeshadow added the question Further information is requested label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@activeshadow activeshadow

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@activeshadow