Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning scheme #8

Closed
nschloe opened this issue Oct 30, 2015 · 1 comment
Closed

versioning scheme #8

nschloe opened this issue Oct 30, 2015 · 1 comment

Comments

@nschloe
Copy link
Contributor

nschloe commented Oct 30, 2015

SEACAS's versioning scheme set the SEACAS_VERSION string incorrectly. It is really composed of major and minor version. Compare Trilinos:

SET(Trilinos_VERSION 12.5)
SET(Trilinos_MAJOR_VERSION 12)
SET(Trilinos_MAJOR_MINOR_VERSION 120500)
SET(Trilinos_VERSION_STRING "12.5 (Dev)")

Besides, a YEAR.MONTH scheme seems to be in place. This is probably to immediately recognize if a version is outdated or not.

However, this approach has flaws. One obvious shortcoming is that you cannot make two releases shortly after one another. More importantly, though, SEACAS is missing out on the semantic meaning of major and minor versions. Typically, a major version change indicates an API change, a minor version indicates that functionality has been added in a backwards-compatible way.

@gsjaardema
Copy link
Member

Changed. The cmake-built version has been deemed to start at 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants