Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model Name Component #593

Closed
pjcross opened this issue Feb 19, 2016 · 3 comments
Closed

Model Name Component #593

pjcross opened this issue Feb 19, 2016 · 3 comments
Assignees
@alexsielicki
Labels
bug CCA Model enhancement

Comments

@pjcross
Copy link
Contributor

pjcross commented Feb 19, 2016

Make a component out of our current model name tab (name, description, marking type).
@pjcross
Copy link
Contributor Author

pjcross commented Feb 19, 2016

Not sure if I should put this in a separate issue...but for this tab in the CCA model wizard, we were seeing two types of errors: issues with sizing the dialog (this was in Safari on OSX) and being kicked out of the model creation wizard when hitting enter while the cursor was in the name field.

@alexsielicki
Copy link
Collaborator

Turns out this is already a component. I will work on the resizing and enter keypress issues.

alexsielicki added a commit that referenced this issue Feb 24, 2016
@alexsielicki
Removing Cancel and Close buttons and replacing with close icon for P…
5fc3a26 
…S. Addresses #593
alexsielicki added a commit that referenced this issue Feb 24, 2016
@alexsielicki
Removing Cancel and Close buttons and replacing with close icon for C…
bfb26c8 
…CA and Select Columns. Addresses #593
alexsielicki added a commit that referenced this issue Feb 25, 2016
@alexsielicki
Removing Cancel and Close buttons and replacing with close icon for r…
955d1d6 
…est of modals. Addresses #593
alexsielicki added a commit that referenced this issue Feb 25, 2016
@alexsielicki
Preventing bootstrap modals from dismissing when hitting enter key in…
ad51589 
… name field. Addresses #593
alexsielicki added a commit that referenced this issue Feb 26, 2016
@alexsielicki
Fixing issue with extra resize handles in Safari. Addresses #593
9214d35
alexsielicki added a commit that referenced this issue Feb 2, 2017
@alexsielicki
Removing Cancel and Close buttons and replacing with close icon for P…
8fb171d 
…S. Addresses #593
alexsielicki added a commit that referenced this issue Feb 2, 2017
@alexsielicki
Removing Cancel and Close buttons and replacing with close icon for C…
643b1ad 
…CA and Select Columns. Addresses #593
alexsielicki added a commit that referenced this issue Feb 2, 2017
@alexsielicki
Removing Cancel and Close buttons and replacing with close icon for r…
741bd02 
…est of modals. Addresses #593
alexsielicki added a commit that referenced this issue Feb 2, 2017
@alexsielicki
Preventing bootstrap modals from dismissing when hitting enter key in…
40b3816 
… name field. Addresses #593
alexsielicki added a commit that referenced this issue Feb 2, 2017
@alexsielicki
Fixing issue with extra resize handles in Safari. Addresses #593
2ea4430
@pjcross
Copy link
Contributor Author

pjcross commented Jan 8, 2018

This was fixed long ago and should have been closed.

@pjcross pjcross closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexsielicki alexsielicki

Labels
bug CCA Model enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexsielicki @pjcross