Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete project button visible to non-administrators #778

Closed
pjcross opened this issue Oct 25, 2017 · 1 comment
Closed

Delete project button visible to non-administrators #778

pjcross opened this issue Oct 25, 2017 · 1 comment
Assignees
Labels

Comments

@pjcross
Copy link
Contributor

pjcross commented Oct 25, 2017

Presumably only a project administrator has the ability to delete the project. Consequently, non-administrators should not see the 'Delete' button at the project level. As a non-administrator, I can click on it and enter into the deletion dialog, though when I click the button to confirm 'Delete Project', nothing happens (so we are checking my role at this point). Although I can't actually delete the project, the dialog remains. Rather than adding error messages to let me know what happened and why, I think it is cleaner to remove the 'Delete' button altogether (just as we do the 'Edit' button now).

@alexsielicki
Copy link
Collaborator

I tested all combinations of roles across models, projects, and the site root and found other problems. Here's a summary:

  1. Readers get "Create Model" functionality at the project level, however it does not work.
  2. Readers get "Create Model" functionality at the model level, however it does not work.
  3. Readers get "Create New Bookmark", "Edit Bookmark", and "Delete Bookmark" functionality at the model level, however it does not work.

Working on resolving all these.

alexsielicki added a commit that referenced this issue Oct 31, 2017
… writers and readers from getting menus for deleting projects. Preventing readers from getting menus for deleting models. Addresses #778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants