Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parameter space csv parser using pandas. #1131

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fixed parameter space csv parser using pandas. #1131

merged 1 commit into from
Jul 11, 2023

Conversation

smartin71
Copy link
Contributor

@smartin71 smartin71 commented Jul 3, 2023

Made parameter space csv parser more robust using pandas. Would like to merge it to master.
Added .csv files for testing in slycat-data under csv-parser-testing.

@alexsielicki
Copy link
Collaborator

I don't see any issues with these changes, but I'm not very strong in Python so @Mletter1 and @Spurs20 should do a deeper review.

@Mletter1 Mletter1 merged commit ed05c08 into master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants