Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for parsing #1149

Merged
merged 57 commits into from
Jan 24, 2024
Merged

Update docs for parsing #1149

merged 57 commits into from
Jan 24, 2024

Conversation

Mletter1
Copy link
Collaborator

@Mletter1 Mletter1 commented Nov 8, 2023

No description provided.

@Mletter1 Mletter1 closed this Nov 8, 2023
@Mletter1 Mletter1 reopened this Nov 8, 2023
@Mletter1 Mletter1 marked this pull request as draft November 8, 2023 19:53
@Mletter1 Mletter1 changed the title DRAFT: Update docs for parsing Draft: Update docs for parsing Nov 8, 2023
@Mletter1 Mletter1 changed the title Draft: Update docs for parsing Update docs for parsing Jan 18, 2024
@Mletter1 Mletter1 marked this pull request as ready for review January 18, 2024 21:16
@Mletter1 Mletter1 requested a review from Spurs20 January 18, 2024 21:16
docs/README.md Outdated

# Adding the docs to the slycat webserver build

You will need to copy the built docs from `/docs/_build` to ~TBA
Copy link
Contributor

@Spurs20 Spurs20 Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~TBA on line 84 needs to be updated to the correct path.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird I think I updated this in f9d1b5b

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see the outdated label on this thread so maybe you were working with the older version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description doesn't match the web service functionality. It was probably added to the wrong doc on accident.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should probably be renamed, and the doc description should be updated. This function name does not match the actual functionality.

@@ -2,4 +2,4 @@
# DE-NA0003525 with National Technology and Engineering Solutions of Sandia, LLC, the U.S. Government
# retains certain rights in this software.

__version__ = "3.1.1"
__version__ = "3.4.2"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct for tag this commit will become

@Spurs20 Spurs20 merged commit 4c40c6b into master Jan 24, 2024
@Spurs20 Spurs20 deleted the update-docs-for-parsing branch January 24, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants