Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first text for snapshot workflow example #162

Merged
merged 26 commits into from
Feb 10, 2022

Conversation

jrood-nrel
Copy link
Collaborator

No description provided.

@jrood-nrel
Copy link
Collaborator Author

https://jrood-nrel.github.io/spack-manager has this pushed already so you can see the sphinx rendering.

Copy link
Collaborator

@psakievich psakievich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress. Added some thoughts

docs/snapshot_workflow.md Outdated Show resolved Hide resolved
docs/snapshot_workflow.md Outdated Show resolved Hide resolved
docs/snapshot_workflow.md Outdated Show resolved Hide resolved
docs/snapshot_workflow.md Show resolved Hide resolved
@psakievich psakievich added the documentation Improvements or additions to documentation label Feb 10, 2022
@psakievich psakievich added this to In progress in Developer Tutorial via automation Feb 10, 2022
Copy link
Collaborator

@psakievich psakievich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of including useful_bash_functions.sh into start.sh but I think this change loses the intent behind the quick-* commands. See my comment in #170

start.sh Show resolved Hide resolved
Developer Tutorial automation moved this from In progress to Review in progress Feb 10, 2022
start.sh Outdated Show resolved Hide resolved
start.sh Show resolved Hide resolved
Developer Tutorial automation moved this from Review in progress to Reviewer approved Feb 10, 2022
Copy link
Collaborator

@psakievich psakievich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's make a post about this on slack to let the user base know, and add the remove-spack-prompt function added in #169. I'll post on slack

@psakievich psakievich added deployment-workflow enhancements for making software deployable to end users developer-workflow enhancements for developer workflows labels Feb 10, 2022
@psakievich
Copy link
Collaborator

closes #163

@jrood-nrel jrood-nrel merged commit 48a1551 into sandialabs:main Feb 10, 2022
Developer Tutorial automation moved this from Reviewer approved to Done Feb 10, 2022
@jrood-nrel jrood-nrel deleted the jrood/snapshot_workflow branch February 10, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-workflow enhancements for making software deployable to end users developer-workflow enhancements for developer workflows documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants