Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for original concretizer with externals #266

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

psakievich
Copy link
Collaborator

Based on the diagnosis of spack/spack#28201 we can get clingo to work for our external specs by stripping patches=* variants from the specs.

@psakievich psakievich self-assigned this Apr 26, 2022
@psakievich psakievich added developer-workflow enhancements for developer workflows deployment-workflow enhancements for making software deployable to end users labels Apr 26, 2022
@psakievich psakievich added this to In progress in Dev Tracker via automation Apr 26, 2022
Copy link
Collaborator

@jrood-nrel jrood-nrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

Dev Tracker automation moved this from In progress to Reviewer approved Apr 26, 2022
@psakievich psakievich merged commit 3352c95 into main Apr 26, 2022
@psakievich psakievich deleted the concrete_snap branch April 26, 2022 16:11
Dev Tracker automation moved this from Reviewer approved to Done Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-workflow enhancements for making software deployable to end users developer-workflow enhancements for developer workflows
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants