Simplify boolean expressions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the conditional boolean values were being set using the ternary operator. This change removes ternary operators and uses logical operators to simplify the evaluation.
jgierer12
reviewed
Jun 26, 2019
| @@ -1,17 +1,15 @@ | |||
| export default class Darkmode { | |||
| constructor(options) { | |||
There was a problem hiding this comment.
Suggested change
| constructor(options) { | |
| constructor(options = {}) { |
Then you can leave out all the options && checks
jgierer12
reviewed
Jun 26, 2019
| const buttonColorDark = options && options.buttonColorDark || '#100f2c'; | ||
| const buttonColorLight = options && options.buttonColorLight || '#fff'; | ||
| const label = options && options.label || ''; | ||
| const saveInCookies = options && options.saveInCookies; |
There was a problem hiding this comment.
Suggested change
| const saveInCookies = options && options.saveInCookies; | |
| const saveInCookies = options && !!options.saveInCookies; |
to ensure it's a boolean
There was a problem hiding this comment.
In that case, I'd prefer options && Boolean(options.saveInCookies)
|
@sandoche, what are we going to do about this PR? 🤷♂ |
|
Hi @maacpiash, just need to test it before merging ! I'll do it this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the conditional Boolean values were being set using the ternary operator.
This change removes ternary operators and uses logical operators to simplify the evaluation.