Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specjour does not work with cucumber version >= 1.2.2 #59

Closed
sergiopatricio opened this issue Mar 7, 2014 · 1 comment
Closed

Specjour does not work with cucumber version >= 1.2.2 #59

sergiopatricio opened this issue Mar 7, 2014 · 1 comment

Comments

@sergiopatricio
Copy link

Specjour does not work with cucumber version >= 1.2.2
The problem is in lib/specjour/cucumber/distributed_formatter.rb, more specifically with step_mother.

class DistributedFormatter < ::Cucumber::Formatter::Progress

    def initialize(step_mother, io, options)
      @step_mother = step_mother
      @io = io
      @options = options
      @failing_scenarios = []
      @step_summary = []
    end

    def after_features(features)
      print_summary
      step_mother.scenarios.clear
      step_mother.steps.clear
    end
(...)

The @step_mother variable is not used, instead it is used step_mother that is defined as an attr_reader in ::Cucumber::Formatter::Progress.

The problem is that in cucumber 1.2.2 step_mother was renamed to runtime in this commit: cucumber/common@f74a8da
So the various step_mother used in lib/specjour/cucumber/distributed_formatter.rb are failing.

A quick fix is to replace in lib/specjour/cucumber/distributed_formatter.rb all usages of step_mother by @step_mother.
Tested this with cucumber 1.2.5 and it works.

What do you think about this?
I can submit a pull request with this change of you want.

@sandro
Copy link
Owner

sandro commented Mar 7, 2014

Yeah, a pull request would be great. My current project doesn't use cucumber, so I'm quite behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants