Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new csproj format, drop old things, target AspMvcCore #20

Open
18 tasks done
sandrock opened this issue Mar 9, 2023 · 1 comment
Open
18 tasks done

Use new csproj format, drop old things, target AspMvcCore #20

sandrock opened this issue Mar 9, 2023 · 1 comment
Assignees
@sandrock
Labels
implemented v2.0

Comments

@sandrock
Copy link
Owner

sandrock commented Mar 9, 2023 •
edited

Questions and decisions

v1 and v2 maintenance

  • Use two git branches?

    • (+) dual changes: allows cherry-picking

  • Use two solutions in one git branch?

    • (-) dual changes: copy code or use complex file links and conditional symbols

  • decide how:

    • branch release/v1.1 to maintain v1.1
    • branch release/v1.2 to maintain v1.2
    • branch release/v2.2 to maintain v2.0
    • branch dev/vX/FEATURE for development
    • remove branch master
    • change solution name to avoid IDE craziness

Target frameworks for v2

  • SrkToolkit.Common should have maximum framework compatibility, because there is not much framework-specific code.
    • net40/net45/net46 (for FX aficionados)
    • net6.0/net7.0 (why? / why not?)
    • netstandard2.0 (for whatever else)
  • SrkToolkit.Domain should use the same support as SrkToolkit.Common
  • AspMvc4
    • SrkToolkit.Web.AspMvc4 -> drop support in v2 (old stuff -> use v1)
    • SrkToolkit.Domain.AspMvc4 -> drop support in v2 (old stuff -> use v1)
  • AspMvc5
    • SrkToolkit.Web.AspMvc5 -> drop support in v2 (old stuff -> use v1)
    • SrkToolkit.Domain.AspMvc5 -> drop support in v2 (old stuff -> use v1)
  • AspNetCore2
    • SrkToolkit.Web.AspNetCore2 -> added support in v2
    • SrkToolkit.Domain.AspNetCore2 -> added support in v2
@sandrock sandrock added the v2.0 label Mar 9, 2023
@sandrock sandrock self-assigned this Mar 9, 2023
@sandrock sandrock added the WIP Work in progress by maintainer. label Mar 9, 2023
sandrock added a commit that referenced this issue Mar 10, 2023
@sandrock
migrate csproj to sdk version, move files around, migrate code, comme…
5bdb5af 
…nt non-migrated code... #20
@sandrock sandrock mentioned this issue Mar 10, 2023
Draft
sandrock added a commit that referenced this issue Mar 10, 2023
@sandrock
migrate code, comment non-migrated code... #20
a0a9646
@sandrock sandrock added implemented and removed WIP Work in progress by maintainer. labels Mar 10, 2023
@sandrock
Copy link
Owner Author

The dropping of AspMvc5 projects may not be a thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandrock sandrock

Labels
implemented v2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sandrock