Add endpoint to answer ACME DNS-01 challenges. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulproteus Did I miss anything? |
kentonv
commented
Mar 22, 2020
sandcats/lib/dns.js
Outdated
| @@ -36,7 +36,7 @@ createDomainIfNeeded = function(mysqlQuery) { | |||
| } | |||
| } | |||
|
|
|||
| deleteRecordIfExists = function (wrappedQuery, domain, bareHost) { | |||
| deleteRecordIfExists = function (wrappedQuery, domain, bareHost, type) { | |||
There was a problem hiding this comment.
Now that I look at it, I guess I didn't need to add the type parameter here, since A records and ACME TXT records go on different hostnames anyway. Oh well.
There was a problem hiding this comment.
Actually this is outright wrong, I can't reuse this function. Fixing.
|
Whoops, I misread some docs and thought that ACME challenges required two TXT records, but they actually only require one. |
The Let's Encrypt API will be invoked from the user's own Sandstorm server. The Sandcats.io server only needs to provide a way to publish TXT records to pass ACME challenges.
|
This has been deployed for a while and seems to work. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Let's Encrypt API will be invoked from the user's own Sandstorm server. The Sandcats.io server only needs to provide a way to publish TXT records to pass ACME challenges.