Rearrange apps, update screenshot #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenhack
approved these changes
Jun 18, 2022
There was a problem hiding this comment.
I don't understand under what circumstances the preview does or doesn't get built...
Haven't looked at the rendered change (or the updated screenshot), but I think this is a good idea.
Edit: I see it showed up in the "checks" area. Still confused about how cloudflare pages decides whether or not to comment, but I have looked at it now and it looks good.
|
Yeah, it's weird choice of when to comment that it built it throws me off, but it does always seem to run. As an aside, I really appreciate the well-written CSS for this section of the site, where it handles all of the left/right alternation correctly by itself, not tied to the explicit items. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really not fond of Rocket.Chat, an app which hasn't had any updates or support for a very long time, being the top featured app here. I both swapped it with Etherpad in the list, and updated the Etherpad screenshot to the newest version experience. (I chose to rewrite the sample blurb word for word here... for some reason.)
I figured I'd throw this up for preliminary thoughts, but I also would still like to update the screenshots for Davros and Wekan as well to reflect their current appearance better.