Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandstorm/sandstorm-http-bridge.c++: If execvp() fails, tell user they might need to 'chmod a+x' #1577

Open
paulproteus opened this issue Feb 24, 2016 · 3 comments

Comments

@paulproteus
Copy link
Collaborator

Rationale: https://botbot.me/freenode/sandstorm/2016-02-24/?msg=60803986&page=1

@paulproteus paulproteus self-assigned this Feb 24, 2016
@kentonv
Copy link
Member

kentonv commented Feb 26, 2016

It should be easily possible to detect if executable permissions are the problem (vs. the file not existing at all) with some calls to access(). Please only print a specific suggestion if it is the correct one, otherwise it's really confusing when the suggestion is wrong.

(True story: Every time my build files and our Makefile tells me to try running make update-deps, I am actually confused for a few seconds.)

@paulproteus
Copy link
Collaborator Author

paulproteus commented Feb 26, 2016 via email

@paulproteus
Copy link
Collaborator Author

I haven't done this yet, so I'll deassign. I hope to get to it, though, but if someone else beats me to it, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants