Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Function that recommends sandstorm/jessie64 #244

Closed
ocdtrekkie opened this issue Jan 21, 2020 · 2 comments · Fixed by #257
Closed

Cleanup: Function that recommends sandstorm/jessie64 #244

ocdtrekkie opened this issue Jan 21, 2020 · 2 comments · Fixed by #257
Assignees

Comments

@ocdtrekkie
Copy link
Collaborator

ocdtrekkie commented Jan 21, 2020

So this function mostly just checks if a specific version of the jessie box is in use and complains about it. vagrant-spk now defaults to stretch, it's actually the box this function that recommends which no longer exists at all and doesn't work, and we've settled on official contrib boxes working fine.

https://github.com/sandstorm-io/vagrant-spk/blob/master/vagrant-spk#L320

Honestly we can probably mostly get rid of this? If anything maybe we should check for uses of sandstorm/jessie64 and recommend they change it to debian/contrib-jessie64... or stretch64.

@zenhack
Copy link
Collaborator

zenhack commented Jan 21, 2020

Yeah I'd be in favor of just deleting that whole swath of code.

@ocdtrekkie
Copy link
Collaborator Author

I might look at doing the thing where we detect if they were trying to use the sandstorm/ box, just because it's been such a prevalent complaint when people try to rebuild apps, and I don't see it not being a question soon. But even that would be shorter/cleaner than this.

@ocdtrekkie ocdtrekkie added this to the vagrant-spk 1.0 milestone Jan 22, 2020
@ocdtrekkie ocdtrekkie self-assigned this Jan 28, 2020
@ocdtrekkie ocdtrekkie linked a pull request Feb 6, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants