Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
Super simple for now. It grabs the same code as setupvm but just for Vagrantfile and global-setup.sh, which shouldn't generally be modified by app packagers.
As a test, I grabbed the GitWeb source prior to @abliss updates, because I knew he hit the 404 box issue. Went through the flow and failed to start the VM. I ran
vagrant-spk upgradevm
and then I was able to start up the VM. (Although I also got a 502 Bad Gateway because there was other related bitrot for GitWeb.)Note that currently neither
setupvm
norupgradevm
has any sort of protection to prevent you from clobbering what you have. (This is worse in setupvm's case, because it can mess up your app build.) Though hopefully people are committing to GitHub or have original sources to fall back on. But we can do better here. We should also put comments at the top of both files we upgrade this way to further discourage user customization to make this command 'safer'.Also, I'm not yet detecting the box that caused GitWeb to 404, and we're going to amend the detection for that to do so.