Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade base box to Bullseye #331

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Upgrade base box to Bullseye #331

merged 4 commits into from
Sep 12, 2022

Conversation

ocdtrekkie
Copy link
Collaborator

I think we need to address #330 before we merge this, and I also am going to do some testing against our test packages yet. We still need good test packages for some stacks (#298), which is also arguably blocking #290.

This also fixes #255. Node 14 is a supported LTS releae, and node-capnp supports Node 14, so we'll bump that up to be relatively modern as well.

@ocdtrekkie ocdtrekkie added this to the vagrant-spk 1.2 milestone Jul 14, 2022
@ocdtrekkie
Copy link
Collaborator Author

PHP test app is good, I submitted fixes for other issues unrelated to the base box upgrade.

Python stack is currently broken, with default: E: Package 'python-virtualenv' has no installation candidate. I think it's probably a safe assumption that's a Python 2 vs. 3 issue, which means we probably need to update our sample app for Python 3. I'm not looking at that tonight, but I'll document it here as a blocker to merging this PR.

@ocdtrekkie ocdtrekkie marked this pull request as ready for review September 6, 2022 03:42
@ocdtrekkie
Copy link
Collaborator Author

Okay, @zenhack, this is ready for your review. Note that on my Windows box, I had to run virtualenv --copies in build.sh to avoid the symlink issue, but I don't feel we should change that by default because it can be very wasteful in packaging output.

sandstorm-io/python-app-to-package-for-sandstorm#4 is the simultaneously-needed update to our test app.

@ocdtrekkie
Copy link
Collaborator Author

Hmmm, I just pushed that last commit on here for Node, before realizing we waited last time until node-capnp was supported. I don't think apps actually necessarily need node-capnp, and we don't currently have a test app either for that stack, so I think for the moment, I would be in favor of just keeping current as Node 14 goes EOL in a handful of months, and we push actual vagrant-spk releases rarely.

Copy link
Collaborator

@zenhack zenhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I agree with keeping node current, rather than waiting for node-capnp to catch up.

@ocdtrekkie ocdtrekkie merged commit 7dece57 into master Sep 12, 2022
@ocdtrekkie ocdtrekkie deleted the bullseye branch September 12, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Node stack to 12, transition 10 to node10 stack
2 participants