New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add advanced markers #192
Conversation
@sandydoo I've made the changes you had requested in the old PR. Please have a look. 🙏 |
@sandydoo For some reason the tests that I added aren't passing. I'll try to get them working and you can then review this PR. |
@sandydoo I've fixed all the tests. Please review. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few more fixes and we'll be good to go
Co-authored-by: sander <sandermel94@gmail.com>
OK. @sandydoo I've done all the requested changes. |
Co-authored-by: sander <sandermel94@gmail.com>
Co-authored-by: sander <sandermel94@gmail.com>
OK. All tests passing with all your recommendations ✅ @sandydoo |
@colenso, just needs a |
Done ✅ |
@colenso, thanks a bunch! |
Thanks @sandydoo Great collaborating with you on this. Could you please release a new version that includes this feature? |
@sandydoo ☝️ 🙏 🥲 |
Released
|
Since the standard marker is deprecated.