Drop mixins #58
Merged
Drop mixins #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the old mixins. These mixins are hard to maintain and reason about because they hold to much state and are run implicitly, without an explicit order.
- Improve component lifecycle control. - Remove possibility of running initial component setup twice. - Make lifecycle hooks return promises to allow fetching external data. - Add `_createOptions` hook to allow component creators to modify the options before using them. This replaces and improves the ignored/required mixins functionality.
Improve the flow of initial setup of the Overlay component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #45.