Add Npm with node-check-updates #286

yhirano55 · 2017-02-14T10:10:02Z

Sorry, requested again.

houndci-bot · 2017-02-14T10:10:14Z

lib/tachikoma/application.rb

+        sh(*['git', 'commit', '-m', "Npm update #{@readable_time}"]) do
+          # ignore exitstatus
+        end
+        sh(*['git', 'push', @authorized_compare_url, "tachikoma/update-#{@readable_time}"])


Pass array contents as separate arguments.

houndci-bot · 2017-02-14T10:10:14Z

lib/tachikoma/application.rb

+        sh(*%w(npm install -g npm-check-updates))
+        sh(*%w(ncu -u))
+        sh(*['git', 'add', 'package.json']) if File.exist?('package.json')
+        sh(*['git', 'commit', '-m', "Npm update #{@readable_time}"]) do


Pass array contents as separate arguments.

houndci-bot · 2017-02-14T10:10:15Z

lib/tachikoma/application.rb

+        sh(*['git', 'checkout', '-b', "tachikoma/update-#{@readable_time}", @base_remote_branch])
+        sh(*%w(npm install -g npm-check-updates))
+        sh(*%w(ncu -u))
+        sh(*['git', 'add', 'package.json']) if File.exist?('package.json')


Pass array contents as separate arguments.

houndci-bot · 2017-02-14T10:10:15Z

lib/tachikoma/application.rb

+        sh(*['git', 'config', 'user.email', @commiter_email])
+        sh(*['git', 'checkout', '-b', "tachikoma/update-#{@readable_time}", @base_remote_branch])
+        sh(*%w(npm install -g npm-check-updates))
+        sh(*%w(ncu -u))


Pass array contents as separate arguments.

houndci-bot · 2017-02-14T10:10:15Z

lib/tachikoma/application.rb

+        sh(*['git', 'config', 'user.name', @commiter_name])
+        sh(*['git', 'config', 'user.email', @commiter_email])
+        sh(*['git', 'checkout', '-b', "tachikoma/update-#{@readable_time}", @base_remote_branch])
+        sh(*%w(npm install -g npm-check-updates))


Pass array contents as separate arguments.

houndci-bot · 2017-02-14T10:10:15Z

lib/tachikoma/application.rb

+      Dir.chdir("#{Tachikoma.repos_path}/#{@build_for}") do
+        sh(*['git', 'config', 'user.name', @commiter_name])
+        sh(*['git', 'config', 'user.email', @commiter_email])
+        sh(*['git', 'checkout', '-b', "tachikoma/update-#{@readable_time}", @base_remote_branch])


Pass array contents as separate arguments.

houndci-bot · 2017-02-14T10:10:15Z

lib/tachikoma/application.rb

+    def npm
+      Dir.chdir("#{Tachikoma.repos_path}/#{@build_for}") do
+        sh(*['git', 'config', 'user.name', @commiter_name])
+        sh(*['git', 'config', 'user.email', @commiter_email])


Pass array contents as separate arguments.

houndci-bot · 2017-02-14T10:10:15Z

lib/tachikoma/application.rb

@@ -221,6 +221,21 @@ def cocoapods
      end
    end

+    def npm
+      Dir.chdir("#{Tachikoma.repos_path}/#{@build_for}") do
+        sh(*['git', 'config', 'user.name', @commiter_name])


Pass array contents as separate arguments.

coveralls · 2017-02-14T10:12:03Z

Coverage decreased (-0.1%) to 67.742% when pulling 87b5758 on yhirano55:add_npm_with_ncu into 497879a on sanemat:master.

coveralls · 2017-02-14T10:12:03Z

Coverage decreased (-0.1%) to 67.742% when pulling 87b5758 on yhirano55:add_npm_with_ncu into 497879a on sanemat:master.

coveralls · 2017-02-14T10:12:03Z

Coverage decreased (-0.1%) to 67.742% when pulling 87b5758 on yhirano55:add_npm_with_ncu into 497879a on sanemat:master.

coveralls · 2017-02-14T10:12:03Z

Coverage decreased (-0.1%) to 67.742% when pulling 87b5758 on yhirano55:add_npm_with_ncu into 497879a on sanemat:master.

coveralls · 2017-02-14T10:12:03Z

Coverage decreased (-0.1%) to 67.742% when pulling 87b5758 on yhirano55:add_npm_with_ncu into 497879a on sanemat:master.

yhirano55 · 2017-03-15T09:40:59Z

@sanemat Please review, and tell me so if there is a problem in this PR.

sanemat · 2017-03-15T14:34:36Z

lib/tachikoma/application.rb

+        sh(*['git', 'config', 'user.name', @commiter_name])
+        sh(*['git', 'config', 'user.email', @commiter_email])
+        sh(*['git', 'checkout', '-b', "tachikoma/update-#{@readable_time}", @base_remote_branch])
+        sh(*%w(npm install -g npm-check-updates))


install is out of tachikoma gem range.

Thanks for your review and maintain a good tool tachikoma.
I see. I'll remove it.

sanemat · 2017-03-15T14:35:28Z

README.md

@@ -22,6 +22,7 @@ You can use these strategies:
 - Bundler (Ruby)
 - Carton (Perl)
 - David (Node.js)
+- Npm (Node.js)


node-check-updates is node-check-updates.

Sorry, does it mean to change to node-check-updates from Npm?

Yes, I prefer npm-check-updates (Node.js).
node- is my typo 😭

I see.., I'll fix it. thanks.

houndci-bot · 2017-03-16T01:12:36Z

lib/tachikoma/application.rb

+        sh(*['git', 'commit', '-m', "Ncu update #{@readable_time}"]) do
+          # ignore exitstatus
+        end
+        sh(*['git', 'push', @authorized_compare_url, "tachikoma/update-#{@readable_time}"])


Pass array contents as separate arguments.

yhirano55 · 2017-03-16T01:14:05Z

README.md

@@ -22,6 +22,7 @@ You can use these strategies:
 - Bundler (Ruby)
 - Carton (Perl)
 - David (Node.js)
+- npm-check-updates (Node.js)


Changed to npm-check-updates from Npm.

coveralls · 2017-03-16T01:14:41Z

Coverage decreased (-0.1%) to 67.742% when pulling b439a0b on yhirano55:add_npm_with_ncu into 497879a on sanemat:master.

yhirano55 · 2017-03-16T01:15:09Z

lib/tachikoma/application.rb

+        sh(*['git', 'config', 'user.name', @commiter_name])
+        sh(*['git', 'config', 'user.email', @commiter_email])
+        sh(*['git', 'checkout', '-b', "tachikoma/update-#{@readable_time}", @base_remote_branch])
+        sh(*%w(ncu -u))


Removed execution for installation.

yhirano55 · 2017-03-16T01:15:40Z

lib/tachikoma/application.rb

@@ -221,6 +221,20 @@ def cocoapods
      end
    end

+    def ncu


Changed a method name to ncu from npm.

yhirano55 · 2017-03-16T01:24:37Z

@sanemat I have pushed modified codes and squished them. Please review again.

sanemat

LGTM

sanemat · 2017-03-16T14:27:16Z

💯
Thanks for your contribution!

houndci-bot reviewed Feb 14, 2017

View reviewed changes

sanemat reviewed Mar 15, 2017

View reviewed changes

Yoshiyuki Hirano added 3 commits March 16, 2017 10:10

add ncu (npm-check-updates)

ead6804

add execute command

614bdc5

add npm-check-updates in strategies

b439a0b

houndci-bot reviewed Mar 16, 2017

View reviewed changes

yhirano55 commented Mar 16, 2017

View reviewed changes

sanemat approved these changes Mar 16, 2017

View reviewed changes

sanemat merged commit 83bfeb9 into sanemat:master Mar 16, 2017

yhirano55 deleted the add_npm_with_ncu branch March 17, 2017 00:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Npm with node-check-updates #286

Add Npm with node-check-updates #286

yhirano55 commented Feb 14, 2017

houndci-bot Feb 14, 2017

houndci-bot Feb 14, 2017

houndci-bot Feb 14, 2017

houndci-bot Feb 14, 2017

houndci-bot Feb 14, 2017

houndci-bot Feb 14, 2017

houndci-bot Feb 14, 2017

houndci-bot Feb 14, 2017

coveralls commented Feb 14, 2017

coveralls commented Feb 14, 2017

coveralls commented Feb 14, 2017

coveralls commented Feb 14, 2017

coveralls commented Feb 14, 2017

yhirano55 commented Mar 15, 2017

sanemat Mar 15, 2017

yhirano55 Mar 15, 2017

sanemat Mar 15, 2017

yhirano55 Mar 15, 2017

sanemat Mar 15, 2017

yhirano55 Mar 15, 2017

houndci-bot Mar 16, 2017

yhirano55 Mar 16, 2017

coveralls commented Mar 16, 2017 •

edited

Loading

yhirano55 Mar 16, 2017

yhirano55 Mar 16, 2017

yhirano55 commented Mar 16, 2017

sanemat left a comment

sanemat commented Mar 16, 2017

@@ @@ -221,6 +221,20 @@ def cocoapods @@
                     end
                   end
+                  def ncu

Add Npm with node-check-updates #286

Add Npm with node-check-updates #286

Conversation

yhirano55 commented Feb 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Feb 14, 2017

coveralls commented Feb 14, 2017

coveralls commented Feb 14, 2017

coveralls commented Feb 14, 2017

coveralls commented Feb 14, 2017

yhirano55 commented Mar 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Mar 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yhirano55 commented Mar 16, 2017

sanemat left a comment

Choose a reason for hiding this comment

sanemat commented Mar 16, 2017

coveralls commented Mar 16, 2017 •

edited

Loading