Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread option not passed to kmc #54

Closed
andreas-wilm opened this issue Dec 4, 2015 · 3 comments
Closed

thread option not passed to kmc #54

andreas-wilm opened this issue Dec 4, 2015 · 3 comments
Assignees

Comments

@andreas-wilm
Copy link

Hi,

I noticed that IVA's thread option (which is used for SMALT) is not passed down to KMC (__run_kmc() and _run_kmc_with_script()), even though it also supports multithreading via -t. No big problem, but an easy to implement improvement.

Thanks for IVA
Andreas

@martinghunt
Copy link
Contributor

Hi Andreas,

Thanks for pointing this out. I have vague recollections of having some issues with multithreading kmc on some servers when I was first developing IVA, which is why IVA might not be using it. I'll have a look into it again. As you say, it's easy enough to make the change to the code, I just might have to document some warnings about it.

Martin

@martinghunt martinghunt self-assigned this Jan 15, 2016
@martinghunt
Copy link
Contributor

Hi Andreas,

This is changed in the new version 1.0.3. By default kmc will now use the number of threads given by the --threads option. In case it causes issues, I added a new option --kmc_onethread to force kmc to use 1 thread regardless of the --threads option.

Martin

@andreas-wilm
Copy link
Author

Great. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants