Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL-771 Migrate all samples to use the new filtered_positive fields #167

Closed
1 task
Chris-Friend opened this issue Dec 3, 2020 · 1 comment · Fixed by #170, #185 or #216
Closed
1 task

GPL-771 Migrate all samples to use the new filtered_positive fields #167

Chris-Friend opened this issue Dec 3, 2020 · 1 comment · Fixed by #170, #185 or #216
Assignees
Labels
Beckman integration Beckman integration

Comments

@Chris-Friend
Copy link
Contributor

Chris-Friend commented Dec 3, 2020

User story
In migrating to Beckman, we have added new filtered_positive fields to samples. These simplify the existing "fit to pick" rules distributed throughout various codebases/queries. As such, and before any fit to pick rule changes, we should migrate all old samples to include filtered_positive values in both Mongo and MLWH, and update any queries to simply check the value of the filtered_positive field.

This will also mean we only have to change the fit to pick rules in one place: crawler, where the fields are first set on inserting/updating samples.

Who are the primary contacts for this story
Katy T
Eduardo M
Phil
Chris F

Acceptance criteria
To be considered successful the solution must allow:

Additional context
Add any other context or screenshots about the feature request here.

@rl15 rl15 changed the title GPL-nnn Migrate all samples to use the new filtered_positive fields GPL-771 Migrate all samples to use the new filtered_positive fields Dec 3, 2020
@alexperrin1 alexperrin1 self-assigned this Dec 4, 2020
@pjvv pjvv transferred this issue from sanger/General-Backlog-Items Dec 8, 2020
@pjvv pjvv added the Beckman integration Beckman integration label Dec 8, 2020
@Chris-Friend Chris-Friend self-assigned this Dec 23, 2020
@rl15
Copy link

rl15 commented Jan 7, 2021

From March 2020 to 17th Dec migration = 17H

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beckman integration Beckman integration
Projects
None yet
4 participants