Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL-740 new fit to pick control rules #170

Merged
merged 20 commits into from
Dec 11, 2020

Conversation

harrietc52
Copy link
Contributor

@harrietc52 harrietc52 commented Dec 10, 2020

Closes #167

Changes proposed in this pull request:

  • Updates filtered positive sample rules to V2

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #170 (4a019b1) into develop (ad7c3b4) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
+ Coverage    89.57%   89.71%   +0.14%     
===========================================
  Files           24       24              
  Lines         1746     1770      +24     
  Branches       206      206              
===========================================
+ Hits          1564     1588      +24     
  Misses         142      142              
  Partials        40       40              
Impacted Files Coverage Δ
crawler/constants.py 100.00% <100.00%> (ø)
crawler/file_processing.py 87.27% <100.00%> (-0.03%) ⬇️
crawler/filtered_positive_identifier.py 100.00% <100.00%> (ø)
migrations/helpers/dart_samples_update_helper.py 82.78% <100.00%> (ø)
...ations/helpers/update_filtered_positives_helper.py 100.00% <100.00%> (ø)
migrations/update_filtered_positives.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7c3b4...4a019b1. Read the comment docs.

@harrietc52 harrietc52 linked an issue Dec 10, 2020 that may be closed by this pull request
2 tasks
@Chris-Friend Chris-Friend changed the title Gpl-740 and GPL-699 GPL-699 new fit to pick control rules Dec 11, 2020
@Chris-Friend Chris-Friend changed the title GPL-699 new fit to pick control rules GPL-740 new fit to pick control rules Dec 11, 2020
Chris-Friend
Chris-Friend previously approved these changes Dec 11, 2020
README.md Outdated Show resolved Hide resolved
crawler/filtered_positive_identifier.py Outdated Show resolved Hide resolved
@Chris-Friend Chris-Friend merged commit 97cb0fc into develop Dec 11, 2020
@Chris-Friend Chris-Friend deleted the GPL-740-update-positive-filter branch December 11, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants