Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL-763 Add sync validation check to destination creation on Beckman #196

Closed
3 tasks
andrewsparkes opened this issue Nov 26, 2020 · 1 comment
Closed
3 tasks
Labels
Beckman integration Beckman integration invalid This doesn't seem right

Comments

@andrewsparkes
Copy link
Member

User story
As developers we would like to add a validation check for use of the destination plate view, in order to cope with the potential synchronization delay between the local databases on the individual robots and the central DART database that the view operates from. Proposal is for Beckman to add a 'number_of_samples' property at the end of the run as they complete the destination then call the API endpoint. If on our side we can see that property on the plate, and the number of samples matches what we get back from the view, then we can proceed with the destination creation. If the property is not there yet, or the number of samples does not align, delay and retry a set number of times before erroring. The Beckman method should wait for a response.

Who are the primary contacts for this story
Eduardo, Chris, Alex, Pjil, Andrew

Acceptance criteria
To be considered successful the solution must allow:

  • Beckman need to add a new plate property to the destination plate 'number_of_samples' that reflects the correct number of controls plus picked positives in the plate
  • The API endpoint code looks for this new property, and only creates the destination plate in the LIMS if present and the number of samples matches the view data.
  • Beckman need to wait on the response that may be delayed.

Dependencies
This story is blocked by the following dependencies:
Beckman need to agree and make the necessary changes to their method.
#145
https://github.com/sanger/General-Backlog-Items/issues/76

Additional context
Consider also story https://github.com/sanger/General-Backlog-Items/issues/79
This is the backup screen for creating a destination. Likely if this is being used that the robot method ended prematurely and the destination has not got the 'number_of_samples' property.

@andrewsparkes andrewsparkes added Beckman integration Beckman integration invalid This doesn't seem right labels Nov 26, 2020
@andrewsparkes
Copy link
Member Author

Likely not required. Decision to remove syncing and have robots access the central DART database directly.
So validation not then needed.

@rl15 rl15 changed the title GPL-nnn Add sync validation check to destination creation on Beckman GPL-763 Add sync validation check to destination creation on Beckman Dec 2, 2020
@rl15 rl15 closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beckman integration Beckman integration invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants