Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-670-4 Pass a Lighthouse specific API key to Sequencescape calls #796

Closed
1 of 5 tasks
sdjmchattie opened this issue Jul 6, 2023 · 3 comments
Closed
1 of 5 tasks
Assignees
Labels
Security Pull requests that address a security vulnerability Size: S Small - low effort & risk

Comments

@sdjmchattie
Copy link
Contributor

sdjmchattie commented Jul 6, 2023

User story
As a Lighthouse maintainer, I want to authenticate with a unique key when passing requests to Sequencescape.

Who are the primary contacts for this story
sm49 hc6

Acceptance criteria
To be considered successful the solution must allow:

  • Update the config for the app to accept an API key for Sequencescape calls on the v2 API.
  • Ensure the deployment project sets this key on deployed versions.
  • Update the app to always provide this key in the headers for v2 SS endpoints.
  • Redeploy with an app specific API key for Sequencescape.
  • Check that requests coming from the app into Sequencescape are using the API key.

References
This story has a non-blocking relationship with:

@sdjmchattie sdjmchattie added the Security Pull requests that address a security vulnerability label Jul 6, 2023
@KatyTaylor KatyTaylor added the Size: S Small - low effort & risk label Oct 24, 2023
@BenTopping BenTopping self-assigned this Nov 22, 2023
@BenTopping
Copy link
Contributor

BenTopping commented Nov 22, 2023

Looks like this is already done? 8a8ca95#diff-1fb8a60a8dbfa17177f69255eb185894c5e97ddc6afc01fa18a31075f57590e6
Maybe the intended target was lighthouse-ui?

@sdjmchattie
Copy link
Contributor Author

Maybe it was done. I doubt it since that commit was 2021. I think the key to this issue was that there wasn't an API key specifically for Lighthouse to access SequenceScape before. It was a generic one used across applications. So if you have already updated the key in Lighthouse to have one that was made especially for it, then this probably is done, yes.

@BenTopping
Copy link
Contributor

Hi Stuart, hope all is well 👋 . Checked the deployment project and lighthouse's prod config and it looks like it is using its own key now so going to close this issue. P.S You may get a few more notifications as we work through these stories sorry!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Pull requests that address a security vulnerability Size: S Small - low effort & risk
Projects
None yet
Development

No branches or pull requests

3 participants