Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-nnn Check plate existence #400

Merged
merged 6 commits into from
Jul 20, 2021
Merged

DPL-nnn Check plate existence #400

merged 6 commits into from
Jul 20, 2021

Conversation

pjvv
Copy link
Contributor

@pjvv pjvv commented Jul 19, 2021

Closes #399

Changes proposed in this pull request:

  • add check for destination plate in SS

@pjvv pjvv requested review from emrojo and andrewsparkes and removed request for emrojo July 19, 2021 15:30
@pjvv pjvv marked this pull request as draft July 19, 2021 15:30
emrojo
emrojo previously approved these changes Jul 19, 2021
Copy link
Contributor

@emrojo emrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

lighthouse/helpers/plates.py Outdated Show resolved Hide resolved
lighthouse/blueprints/plates.py Outdated Show resolved Hide resolved
lighthouse/blueprints/plates.py Outdated Show resolved Hide resolved
lighthouse/classes/messages/sequencescape_messages.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #400 (dccc39e) into develop (87bc491) will decrease coverage by 0.00%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #400      +/-   ##
===========================================
- Coverage    92.25%   92.25%   -0.01%     
===========================================
  Files           93       93              
  Lines         3048     3073      +25     
  Branches       245      248       +3     
===========================================
+ Hits          2812     2835      +23     
- Misses         193      195       +2     
  Partials        43       43              
Impacted Files Coverage Δ
lighthouse/helpers/plates.py 93.75% <92.59%> (-0.26%) ⬇️
lighthouse/blueprints/plates.py 91.54% <100.00%> (+0.37%) ⬆️
lighthouse/constants/general.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87bc491...dccc39e. Read the comment docs.

@pjvv pjvv marked this pull request as ready for review July 20, 2021 09:43
@pjvv pjvv merged commit 8232aeb into develop Jul 20, 2021
@pjvv pjvv deleted the dpl-nnn-check-plate-existence branch July 20, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-080 Check plate existence in Sequencescape
3 participants