GPL-568 increase max results limit for endpoint #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults=10000 and it will work - real reason is because for GPL-568, in lighthouse-ui Imports page we want to return all imports at once (~350 records at the moment) - previous limit was 50, as that is the default - see Eve documentation
Codecov Report
@@ Coverage Diff @@
## develop #77 +/- ##
===========================================
+ Coverage 83.29% 83.33% +0.03%
===========================================
Files 13 13
Lines 455 456 +1
Branches 53 53
===========================================
+ Hits 379 380 +1
Misses 70 70
Partials 6 6
Continue to review full report at Codecov.
|
BenTopping
approved these changes
Aug 3, 2020
harrietc52
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set pagination limit so that requests to this endpoint can put ?max_results=10000 and it will work